Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): Show Celery cohort queries in CH debug modal #21173

Merged
merged 14 commits into from
Apr 2, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Mar 26, 2024

Problem

Debugging an issue with cohorts, but I don't know what the actual query was, because it isn't attributed to the user who saved the cohort.

Changes

Cohort queries should now be attributed to the user, if it was indeed user-initiated.

How did you test this code?

Updated cohort API's test_creating_update_and_calculating.

This comment was marked as off-topic.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Size Change: +71 B (0%)

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 824 kB +71 B (0%)

compressed-size-action

@Twixes Twixes marked this pull request as ready for review April 2, 2024 13:44
@Twixes Twixes requested a review from a team April 2, 2024 13:44
Copy link
Contributor

@webjunkie webjunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful 👍🏻

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense & looks good minus an annotation regarding a type issue.

>
Refresh
</LemonButton>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wanted to use the button quite often when there were no results yet.

@Twixes Twixes enabled auto-merge (squash) April 2, 2024 16:27
@Twixes Twixes merged commit 1dcffff into master Apr 2, 2024
83 checks passed
@Twixes Twixes deleted the cohort-queries-in-debug branch April 2, 2024 17:56
Copy link

sentry-io bot commented Apr 2, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ CHQueryErrorTooManySimultaneousQueries: Code: 202. posthog.tasks.calculate_cohort.calculate_cohort_ch View Issue
  • ‼️ CHQueryErrorTooManySimultaneousQueries: Code: 202. posthog.tasks.calculate_cohort.calculate_cohort_ch View Issue
  • ‼️ CHQueryErrorTimeoutExceeded: Code: 159. posthog.tasks.calculate_cohort.calculate_cohort_ch View Issue
  • ‼️ CHQueryErrorTooManySimultaneousQueries: Code: 202. posthog.tasks.calculate_cohort.calculate_cohort_ch View Issue
  • ‼️ CHQueryErrorTableIsReadOnly: Code: 242. posthog.tasks.calculate_cohort.calculate_cohort_ch View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants